helppokersource - Support: sr #2273, Reassigned to another tracker...

 
 
Show feedback again

sr #2273: Reassigned to another tracker [was: PokerService.createTable() should fail if insert fails]

Submitted by:  Bradley M. Kuhn <bkuhn>
Submitted on:  Mon 16 Feb 2009 11:33:38 PM UTC  
 
Category: poker-networkPriority: 5 - Normal
Severity: 3 - NormalStatus: Confirmed
Privacy: PublicAssigned to: None
Open/Closed: ClosedOperating System: None
Effort: 0.00

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 24 Jun 2009 05:42:50 PM UTC, comment #3:

THIS ITEM WAS REASSIGNED TO BUG #13777.

Please, do not post any new comments to this item.


Bradley M. Kuhn <bkuhn>
Project Administrator
Sat 04 Apr 2009 03:51:52 PM UTC, SVN revision 5604:

Merged coverage-poker-network branch into trunk for 100% pokerservice.py coverage:
* Wrote numerous tests in test-pokerservice.py.in
* raise NotImplementedError() in getArguments() and maps2result() in
PokerXML. Closes sr #2274
* Created test-pokerservice-load.py.in, which meta-tests various loading
conditions of pokerservice.py
* Comments to note failed insert should return None in
PokerService.createTable(). See sr #2273
* Made notes about PokerPlayerInfoLocale in pokerservice.py and
pokerpackets.py, see sr #2262
* run.in now has pokerservice.py listed for 100% coverage!
* test-pokerservice-load.py.in and test-pokerservice-load.py call each
other via compile-command variable.
* Added test-pokerservice-load.py.in to configure.ac
* Minor fix to a comment in test-pokeravatar.py.in
* Detailed ChangeLog entries for what was done.

(Browse SVN revision 5604)

Bradley M. Kuhn <bkuhn>
Project Administrator
Mon 16 Feb 2009 11:42:36 PM UTC, SVN revision 5543:

Added a commented-out test that should succeed if sr # 2273 be deemed
valid and closed. Added comments in the test files and source to indicate
existence of sr #2273.

(Browse SVN revision 5543)

Bradley M. Kuhn <bkuhn>
Project Administrator
Mon 16 Feb 2009 11:33:38 PM UTC, original submission:

THIS ITEM WAS REASSIGNED TO BUG #13777.

Currently, the createTable() method in PokerService (found in pokerservice.py) continues on when the INSERT returns 0 rows. It probably should not do this; it should fail in some way, assuming that the table has not been created.

Bradley M. Kuhn <bkuhn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by proppy (Updated the item)
  • -unavailable- added by bkuhn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 23 Feb 2010 05:49:28 PM UTCproppyStatusNone=>Confirmed
    Wed 24 Jun 2009 05:42:50 PM UTCbkuhnReassign Itempokersource, sr #2273=>pokersource, bug #13777
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup