helppokersource - Support: sr #2274, PokerXML base class methods...

 
 
Show feedback again

sr #2274: PokerXML base class methods getArguments() and maps2result() should raise NotImplementedError

Submitted by:  Bradley M. Kuhn <bkuhn>
Submitted on:  Tue 17 Feb 2009 09:31:47 PM UTC  
 
Category: poker-networkPriority: 5 - Normal
Severity: 2 - MinorStatus: None
Privacy: PublicAssigned to: None
Open/Closed: ClosedOperating System: None
Effort: 0.00

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 04 Apr 2009 03:51:52 PM UTC, SVN revision 5604:

Merged coverage-poker-network branch into trunk for 100% pokerservice.py coverage:
* Wrote numerous tests in test-pokerservice.py.in
* raise NotImplementedError() in getArguments() and maps2result() in
PokerXML. Closes sr #2274
* Created test-pokerservice-load.py.in, which meta-tests various loading
conditions of pokerservice.py
* Comments to note failed insert should return None in
PokerService.createTable(). See sr #2273
* Made notes about PokerPlayerInfoLocale in pokerservice.py and
pokerpackets.py, see sr #2262
* run.in now has pokerservice.py listed for 100% coverage!
* test-pokerservice-load.py.in and test-pokerservice-load.py call each
other via compile-command variable.
* Added test-pokerservice-load.py.in to configure.ac
* Minor fix to a comment in test-pokeravatar.py.in
* Detailed ChangeLog entries for what was done.

(Browse SVN revision 5604)

Bradley M. Kuhn <bkuhn>
Project Administrator
Mon 30 Mar 2009 12:00:56 AM UTC, SVN revision 5598:

Per dachary's comment in sr #2274 , raise NotImplementedError() for PokerXML.maps2result/getArguments.

(Browse SVN revision 5598)

Bradley M. Kuhn <bkuhn>
Project Administrator
Wed 18 Feb 2009 12:18:01 AM UTC, comment #2:

I agree. And it would be much easier to test. Feel free to modify the code accordingly since this helps the tests.

Loic Dachary <loic>
Project Administrator
Tue 17 Feb 2009 09:39:28 PM UTC, SVN revision 5551:

Created alternative tests for PokerXMLCoverageTestCase that should be used
instead of test04 and test05 if someone wants to work on sr #2274

(Browse SVN revision 5551)

Bradley M. Kuhn <bkuhn>
Project Administrator
Tue 17 Feb 2009 09:31:47 PM UTC, original submission:

Instead of being simply "pass"'s, I think getArguments() and maps2result() in PokerXML, the base class, should probably:
raise NotImplementedError

Bradley M. Kuhn <bkuhn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by loic (Posted a comment)
  • -unavailable- added by bkuhn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 04 Apr 2009 03:54:44 PM UTCbkuhnOpen/ClosedOpen=>Closed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup