helppokersource - Support: sr #2274, PokerXML base class methods...

Show feedback again

sr #2274: PokerXML base class methods getArguments() and maps2result() should raise NotImplementedError

Submitted by:  Bradley M. Kuhn <bkuhn>
Submitted on:  Tue Feb 17 21:31:47 2009  
Category: poker-networkPriority: 5 - Normal
Severity: 2 - MinorStatus: None
Privacy: PublicAssigned to: None
Open/Closed: ClosedOperating System: None
Effort: 0.00

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sat Apr 4 15:51:52 2009, SVN revision 5604:

Merged coverage-poker-network branch into trunk for 100% coverage:
* Wrote numerous tests in
* raise NotImplementedError() in getArguments() and maps2result() in
PokerXML. Closes sr #2274
* Created, which meta-tests various loading
conditions of
* Comments to note failed insert should return None in
PokerService.createTable(). See sr #2273
* Made notes about PokerPlayerInfoLocale in and, see sr #2262
* now has listed for 100% coverage!
* and call each
other via compile-command variable.
* Added to
* Minor fix to a comment in
* Detailed ChangeLog entries for what was done.

(Browse SVN revision 5604)

Bradley M. Kuhn <bkuhn>
Project Administrator
Mon Mar 30 00:00:56 2009, SVN revision 5598:

Per dachary's comment in sr #2274 , raise NotImplementedError() for PokerXML.maps2result/getArguments.

(Browse SVN revision 5598)

Bradley M. Kuhn <bkuhn>
Project Administrator
Wed Feb 18 00:18:01 2009, comment #2:

I agree. And it would be much easier to test. Feel free to modify the code accordingly since this helps the tests.

Loic Dachary <loic>
Project Administrator
Tue Feb 17 21:39:28 2009, SVN revision 5551:

Created alternative tests for PokerXMLCoverageTestCase that should be used
instead of test04 and test05 if someone wants to work on sr #2274

(Browse SVN revision 5551)

Bradley M. Kuhn <bkuhn>
Project Administrator
Tue Feb 17 21:31:47 2009, original submission:

Instead of being simply "pass"'s, I think getArguments() and maps2result() in PokerXML, the base class, should probably:
raise NotImplementedError

Bradley M. Kuhn <bkuhn>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by loic (Posted a comment)
  • -unavailable- added by bkuhn (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat Apr 4 15:54:44 2009bkuhnOpen/ClosedOpen=>Closed
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup