Mon 20 Jun 2005 03:36:18 PM UTC, comment #26:
The merge is done, only bug #2487 remains to be handled. Congrats toddy for the piece of work done :)
|
Mon 20 Jun 2005 02:48:52 PM UTC, comment #25:
The branch seems fine for me, I'll merge it and we'll commit bugfixes on the trunk until 1.0.7 is released.
|
Mon 20 Jun 2005 01:53:04 PM UTC, comment #24:
How looks utf-8 mails with your mailers?
In my cast, the subject line is fine but the content, that is utf-8, is not rendered properly in gnus: it's shown like it were iso-8859-15 while it's really utf-8, it's fine if it pass it through `iconv --from-code utf-8 --to-code iso-8859-15`. It's fine in Squirrelmail.
The odd thing is the fact that I'm able to send mails supposedly in utf-8 with Squirrelmail and read them properly with gnus... (but I'm not 100% sure that Squirrelmail really sent an utf-8 mail, despite the headers).
That's definitely the last thing we should inquire about before the release.
|
Mon 20 Jun 2005 10:11:53 AM UTC, comment #23:
(Tobias, dont think I'm blaming you for anything)
|
Mon 20 Jun 2005 10:03:57 AM UTC, comment #22:
Hum, several comments were lost because there's something very wrong in the way the database backup scripts make backups :((
It makes broken backups.
I did not checked and did not understood that you were not using mysqldump (well, I should have guess, since you wanted at first to avoid using the command line mysql client). And with complex databases like the one of Gna!, indeed we reached several cases were the hand made mysqldump was unable to cope with.
So I was left with a broken database and a broken backup. Hence I had to restore the database with the last proper backup, that I converted (well, not directly the backup, indeed) in UTF-8.
But, well, that's the price of using Gna!. We provide a free and usually efficient service, but we also use it as test platform, the one which help us to caught bug that typically cannot be caught on a test machine.
Quite true, I could have downloaded the database I made it the whole conversion stuff on another machine; I was overconfident on the backup script. But that's quite nasty to provide a backup script that is not safe.
Happy we caught that before the release.
|
Sun 19 Jun 2005 08:21:20 AM UTC, comment #21:
I've fixed the issue with success/error feedback. The problem was a call to the function htmlentities(), which assumes the input to be in latin-1. Thus, the UTF-8 encoding gets escaped into those strange characters. I've replaced the function with a call to htmlspecialchars() everywhere in the code, so that the critical characters (like < > & etc.) are escaped, leaving the rest of the input untouched.
|
Sat 18 Jun 2005 03:40:49 PM UTC, comment #20:
I did it before but I redid it just in case and the result is the same. Everything is fine apart succes/error messages.
|
Sat 18 Jun 2005 01:01:59 PM UTC, comment #19:
> However, the fact that we have a perl script relying on
> Savane libs is in fact helpful, since the user is not forced
> to type password. Have you checked out my changes?
Yes, they are fine. We should keep it this way.
> Finally, yes, the problem occurs only with error/success
> messages. That's what I found strange.
Are you sure that the message is correctly translated in the fr_FR.po file? Please search for "%s will be set to", which turns up the msgid for the message in question. Are the French accents correct in the .po file, or are they somehow messed up?
If everything is correct, please check whether the generated .mo file is correct. If in doubt, regenerate the .mo file and install it.
|
Sat 18 Jun 2005 12:13:33 PM UTC, comment #18:
I think it would be quite unusual (possible though) to have a mysqld running without mysql command being available.
As Savane installation process already relies on it, we should not be worried about using it.
However, the fact that we have a perl script relying on Savane libs is in fact helpful, since the user is not forced to type password. Have you checked out my changes?
Finally, yes, the problem occurs only with error/success messages. That's what I found strange.
|
Sat 18 Jun 2005 11:55:01 AM UTC, comment #17:
Hi,
I'll try to answer some of the comments below.
> BTW, have original database file (in sql/mysql) have been
> converted for fresh installs?
It doesn't seem to be necessary. I converted them into UTF-8 and diff'ed the resulting files against the repository copies. There were no differences. I guess everything in the files is ASCII anyway.
> Looking at your script more carefully, I'm not sure to
> understand why you use perl to do the mysql insert instead of
> a simple dumb
> mysql < my_converted_file.dump
That's because I assumed that I can only rely on Perl being installed, since it's required for Savane anyway. "mysql" on the other hand is a command line client which is not necessary to run the mysql server. If we can rely on the client program mysql being installed, that's certainly the way to go. We should drop the Perl script then.
> So with my little changes to your script, now it seems to
> work. Everything seems to be in UTF-8 but I have an issue
> with the success/error messages.
Does this encoding problem only occur with the success and error messages? The rest of your screenshot shows correct French accents, it seems.
|
Fri 17 Jun 2005 01:45:16 PM UTC, comment #16:
There\'s also an issue with the encoding of mails we should sort out before the release, mentioned in bug #2440
|
Fri 17 Jun 2005 01:43:13 PM UTC, comment #15:
So with my little changes to your script, now it seems to work. Everything seems to be in UTF-8 but I have an issue with the success/error messages.
See the attached screenshot.
Any clues?
|
Fri 17 Jun 2005 01:23:56 PM UTC, comment #14:
Looking at your script more carefully, I'm not sure to understand why you use perl to do the mysql insert instead of a simple dumb
mysql < my_converted_file.dump
I think it gets messy because dbi add quotes when it considers to be necessary but a mysql dumpfile is supposed to be correctly escaped already.
|
Fri 17 Jun 2005 01:15:54 PM UTC, comment #13:
We definitely have to speed up this release that have been delayed for too long because of me. I'm now able to spend the necessary time to test it.
|
Fri 17 Jun 2005 01:14:20 PM UTC, comment #12:
BTW, have original database file (in sql/mysql) have been converted for fresh installs?
|
Fri 17 Jun 2005 01:13:19 PM UTC, comment #11:
root@eos:/home/moa/projects/cvs.gna.org/savane/update/1.0.7# ./convert_database.pl --file=database-backup_001.sql
Converting your database from ISO-8859-1 into UTF-8
DBD::mysql::db do failed: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ''' at line 1 at ./convert_database.pl line 71.
DBD::mysql::db do failed: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ''' at line 1 at ./convert_database.pl line 71.
Still the same with the stuff from the head.
Attached to this mail the database dump that cause the trouble.
|
Sun 12 Jun 2005 08:41:37 PM UTC, comment #10:
Hum, will be done by the end of this week, promise (urf, got an already big list of things to do for this week, but this one has been on the list for too long already)
|
Sun 12 Jun 2005 06:23:30 PM UTC, comment #9:
Hi,
what about some testing of this branch to get the next release going? The "should be finished on"-deadline comes closer :)
|
Thu 12 May 2005 07:03:38 AM UTC, comment #8:
No, I'm sorry, I havent tested further since then (my brother was in Strasbourg for a few days, I was more or less off the net during that period and I have some backlog to handle right now).
|
Wed 11 May 2005 06:26:16 PM UTC, comment #7:
Mathieu,
just a short ping in case you've lost my question in your inbox ...
Did the HEAD version of Util.pm (i.e. quoting of the newline character) fix the error you've encountered, or does the script still fail?
|
Wed 04 May 2005 04:32:14 PM UTC, comment #6:
"In fact, you should not commit on the HEAD a fix that have to go on the branch."
Right, but the fix was not specific to UTF-8, and the function seems to be used in some other places as well, so I thought it would be sensible to commit to HEAD.
Apart from that, did the HEAD version of Util.pm fix your problem?
|
Wed 04 May 2005 04:10:18 PM UTC, comment #5:
" BTW: Should I commit the exact same fix in HEAD and the branch twice? I thought that this could create some confusion, so I refrained from doing so."
In fact, you should not commit on the HEAD a fix that have to go on the branch. The proper way to get such fix on the HEAD is to merge the file with the branch. Otherwise, you only have two option, the one you picked (the most sensible; commiting only on the HEAD) which breaks the branch or commiting on both HEAD and branch which will ends up in merge conflicts later.
|
Wed 04 May 2005 03:48:33 PM UTC, comment #4:
Hm, that's strange. I didn't add any code for handling quotes, because the script operates on a database dump. In this dump (which is SQL) I thought all quotes are already escaped.
However, maybe the failure was not with a quote, but a newline. I changed the file Util.pm in the lib subdirectory a few weeks ago, to handle newlines as well. To make the merge easier, I didn't include the fix in the UTF-8 branch; it is only in HEAD. So could you update your file lib/Savannah/Util.pm back to HEAD and try that script again?
BTW: Should I commit the exact same fix in HEAD and the branch twice? I thought that this could create some confusion, so I refrained from doing so.
|
Wed 04 May 2005 02:43:12 PM UTC, comment #3:
I've got:
Converting your database from ISO-8859-1 into UTF-8
DBD::mysql::db do failed: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ''Replace this paragraph by the technical description of your' a at ./convert_database.pl line 71.
Are you sure you dealth with quotes? Looks like it failed with a quote.
|
Tue 05 Apr 2005 12:04:27 PM UTC, comment #2:
I'll try to test this stuff before the end of the week. If I cant, I'm afraid I wont be able to do it the next week.
|
Mon 04 Apr 2005 03:40:41 PM UTC, comment #1:
I've just completed the README for the conversion and committed three more Perl scripts for the database conversion into UTF-8.
In my opinion, this should be all which needs to be done to prepare the switch to UTF-8.
I'd like people to review my scripts (and general approach) in the branch, read the README, and, if possible, even try to migrate a test install (please don't do this with real data yet).
Comments are welcome.
|
Thu 31 Mar 2005 09:00:41 PM UTC, original submission:
This item is for tracking the progress of the switch to UTF-8, needed for correct I18N of Savane.
What has happened already?
- Initial version of README for update
- Generation of needed locales (UTF-8 enabled version)
- Conversion of site-specific files into UTF-8
- Switch in the PHP frontend to display only UTF-8
What needs still to be done?
- Complete README for update
- Conversion of database into UTF-8
|