bugBattle for Wesnoth - Bugs: bug #19018, [replace_map] produced no warnings...

 
 
Show feedback again

bug #19018: [replace_map] produced no warnings replacing the game map with an empty map, leaving some units off-map

Submitted by:  Espreon <espreon>
Submitted on:  Fri 18 Nov 2011 04:31:51 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: Ready For TestPrivacy: Public
Assigned to: Anonymissimus <anonymissimus>Open/Closed: Closed
Release: 1.9.10+svn (52001:52002)Operating System: Sabayon Linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 17 Jan 2012 10:28:37 PM UTC, SVN revision 52641:

improve an error message (bug #19018)

(Browse SVN revision 52641)

Anonymissimus <anonymissimus>
Project MemberIn charge of this item.
Tue 17 Jan 2012 10:28:08 PM UTC, SVN revision 52640:

Require loaded maps to have at least 1 (non-border) hex (bug #19018)

(This new translatable string is only visible/useful for wml authors,
and we have lots on untranslated wml error messages anyway; also
they really don't need to be translatable)

(Browse SVN revision 52640)

Anonymissimus <anonymissimus>
Project MemberIn charge of this item.
Tue 17 Jan 2012 10:26:33 PM UTC, SVN revision 52638:

Introduce parameter allow_invalid in gamemap::read (fix for bug #19018)

(Browse SVN revision 52638)

Anonymissimus <anonymissimus>
Project MemberIn charge of this item.
Tue 17 Jan 2012 09:03:43 PM UTC, comment #3:

ok :)

Iurii Chernyi <crab>
Project Member
Tue 17 Jan 2012 08:57:31 PM UTC, comment #2:

Crab, may I relief you of one of the countless bugs you have assigned. The reason for why the warning was omitted is that the total_width and height of the new map have still the values of the old map, because the read function doesn't set them in case of an empty map. :)

Anonymissimus <anonymissimus>
Project MemberIn charge of this item.
Tue 27 Dec 2011 01:15:58 PM UTC, comment #1:

[replace_map] was used to replace the game map with an empty map. I need to check why no warnings were produced

Iurii Chernyi <crab>
Project Member
Fri 18 Nov 2011 04:31:51 PM UTC, original submission:

I came across this bug while developing a part of my campaign.

svn: https://wesnoth-umc-dev.svn.sourceforge.net/svnroot/wesnoth-umc-dev/trunk/The_Silver_Lands

To reproduce:

1. Start TSL (the prologue)

2. Enable debug mode

3. :fire desert_room_portal

4. Kill the elemental

5. The game should hang permanently; press "End Turn" to seal the deal. While the game, in reality, has aborted, it will just be up and frozen.

Error:
wesnoth-debug: src/ai/default/contexts.cpp:242: virtual std::vector<ai::target> ai::default_ai_context_impl::find_targets(const ai::move_map&): Assertion `map_.on_board(u->get_location())' failed.

Program received signal SIGABRT, Aborted.
0x00007ffff3d75935 in raise () from /lib64/libc.so.6

Backtrace:

#0 0x00007ffff3d75935 in raise () from /lib64/libc.so.6
#1 0x00007ffff3d76db6 in abort () from /lib64/libc.so.6
#2 0x00007ffff3d6e555 in __assert_fail () from /lib64/libc.so.6
#3 0x0000000000b0ee38 in ai::default_ai_context_impl::find_targets (this=0x7fffd6a50ac0, enemy_dstsrc=std::multimap with 0 elements) at src/ai/default/contexts.cpp:242
#4 0x000000000083ed5d in ai::default_ai_context_proxy::find_targets (this=0x7fffd687b838, enemy_dstsrc=std::multimap with 0 elements)
at src/ai/testing/../composite/../default/contexts.hpp:220
#5 0x0000000000849ba7 in ai::testing_ai_default::testing_move_to_targets_phase::execute (this=0x7fffd687b7a0) at src/ai/testing/ca_testing_move_to_targets.cpp:144
#6 0x000000000086438a in ai::testing_ai_default::candidate_action_evaluation_loop::do_play_stage (this=0x7fffd72ec190) at src/ai/testing/stage_rca.cpp:131
#7 0x0000000000ae6693 in ai::stage::play_stage (this=0x7fffd72ec1b8) at src/ai/composite/stage.cpp:60
#8 0x0000000000ab3183 in ai::ai_composite::play_turn (this=0x7fffd72ec590) at src/ai/composite/ai.cpp:141
#9 0x00000000007a8caa in ai::manager::play_turn (side=2) at src/ai/manager.cpp:740
#10 0x0000000000618edd in playsingle_controller::play_ai_turn (this=0x7fffffffb3c0) at src/playsingle_controller.cpp:841
#11 0x0000000000617e20 in playsingle_controller::play_side (this=0x7fffffffb3c0, team_index=2, save=true) at src/playsingle_controller.cpp:659
#12 0x00000000006179d8 in playsingle_controller::play_turn (this=0x7fffffffb3c0, save=true) at src/playsingle_controller.cpp:590
#13 0x0000000000616242 in playsingle_controller::play_scenario (this=0x7fffffffb3c0, story=..., skip_replay=false) at src/playsingle_controller.cpp:391
#14 0x0000000000608715 in playsingle_scenario (game_config=..., level=0x7fffffffbc60, disp=..., state_of_game=..., story=..., skip_replay=false, end_level=...) at src/playcampaign.cpp:130
#15 0x000000000060afdd in play_game (disp=..., gamestate=..., game_config=..., io_type=IO_NONE, skip_replay=false) at src/playcampaign.cpp:365
#16 0x000000000048b35c in game_controller::launch_game (this=0x1641220, reload=game_controller_abstract::RELOAD_DATA) at src/game_controller.cpp:1267
#17 0x0000000000424696 in do_gameloop (argc=1, argv=0x7fffffffdc28) at src/game.cpp:573
#18 0x0000000000424b93 in main (argc=1, argv=0x7fffffffdc28) at src/game.cpp:627

Espreon <espreon>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by anonymissimus (Posted a comment)
  • -unavailable- added by crab (Posted a comment)
  • -unavailable- added by espreon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 23 Jan 2012 12:02:11 AM UTCivanovicOpen/ClosedOpen=>Closed
    Tue 17 Jan 2012 10:27:38 PM UTCanonymissimusStatusNone=>Ready For Test
    Tue 17 Jan 2012 08:58:46 PM UTCanonymissimusStatusIn Progress=>None
      Assigned tocrab=>anonymissimus
    Tue 27 Dec 2011 01:15:58 PM UTCcrabSummaryAI system-caused freeze and abort=>[replace_map] produced no warnings replacing the game map with an empty map, leaving some units off-map
    Tue 27 Dec 2011 01:15:57 PM UTCcrabStatusNone=>In Progress
    Fri 02 Dec 2011 05:12:41 AM UTCespreonAssigned toNone=>crab
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup