bugBattle for Wesnoth - Bugs: bug #19603, Broken replays at...

 
 
Show feedback again

bug #19603: Broken replays at replays.wesnoth.org

Submitted by:  SlowThinker <slowthinker>
Submitted on:  Fri 30 Mar 2012 06:01:23 PM UTC  
 
Category: BugSeverity: 4 - Important
Priority: 5 - NormalItem Group: Replays
Status: PostponedPrivacy: Public
Assigned to: NoneOpen/Closed: Open
Release: 1.10.1Operating System: Win XP Pro

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 07 Jan 2015 06:17:08 PM UTC, comment #5:

the original bug is most likeley already fixed in master (1.13-dev)

Daniel <gfgtdf>
Project Member
Mon 05 May 2014 10:41:06 PM UTC, comment #4:

The next text is partially off topic, and a feature request.

Think about situations where a player/observer replays
a) from the very beginning (that happens in an off-line replay, from a saved game)
b) from the last load point (that happens in an on-line replay, from server's data)

A replay from the very beginning might be useful also for an on-line observer (in fact from another Wesnoth player I got a question how to do it).
A replay from the last load point might be useful also for an offline replay: it would allow PBEM games ...

(... but only if one could watch the replay from a "Point of view" of side 2, 3 ,4 ... I don't understand why there is the limitation Team 1/Each Team/Full Map;
the choice of a viewpoint would be useful also online - a player who disconnected could rejoin safely and without the blindfold mode, and in the meantime the other player could continue his turn.)

SlowThinker <slowthinker>
Mon 28 Apr 2014 03:58:09 AM UTC, comment #3:

Status:

This has been partially fixed, in that "basic" scenarios should now work in 1.12. We may be able to easily fix campaigns. Currently only the final scenario of the campaign will be saved.

tl,dr:

Making reloaded scenarios work would unfortunately take a good deal of work, and this is something we would have to postpone until after 1.12. The good news is that we can patch the server to fix things like this without breaking compatibility, so it doesn't have to happen before 1.12 is launched.

Long version:

The issue is basically that the replay server is not smart enough to read the replay and keep track of the game state. The replay that is generated is closer to some kind of debugging output -- the [replay] contains all of the "history" of game transactions, and the [replay_start] contains the initial level cfg generated by the host.

This is compounded by the fact that the "history" needs to be okay to send to observers in order to bring them up to date. It's possible that the server could generate replay files by always viewing turn 1 as the start, and merging the "new history" with the reloaded history, but that surgery would have to be done in the final seconds before writing the replay to memory, and it may make it harder to debug other server issues before 1.12.0, so I think this kind of change should wait until after that.

Chris Beck <involution>
Project Member
Wed 12 Mar 2014 07:58:28 PM UTC, comment #2:

tested again with 1.10.7 (but I guess the bug is not related to a Wesnoth version)

this game has been reloaded:
http://replays.wesnoth.org/1.10/20140312/2p__Den_of_Onis_Turn_2_(10571).gz

the final and corrupted replay:
http://replays.wesnoth.org/1.10/20140312/2p__Den_of_Onis_Turn_3_(10573).gz

SlowThinker <slowthinker>
Sun 01 Apr 2012 06:17:17 PM UTC, comment #1:

It looks my original submission was wrong about the way how to reproduce, and the fact whether the hosting player disconnected or not has nothing to do with the bug:
The bug happens if the game has been reloaded.

Summary of my current understanding about the bug:
http://forums.wesnoth.org/viewtopic.php?p=525335#p525335

----------------------------------------------------------
The bug has a common point with this bug: https://gna.org/bugs/?19258

SlowThinker <slowthinker>
Fri 30 Mar 2012 06:01:23 PM UTC, original submission:

A replay gets broken if the hosting player disconnected.

How to reproduce:
1. start a MP game on the official server
2. disconnect the hosting player (for example kill wesnothd.exe)
3. end the game
4. check the replay at replays.wesnoth.org

More details here:
http://forums.wesnoth.org/viewtopic.php?f=4&t=36499

SlowThinker <slowthinker>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gfgtdf (Posted a comment)
  • -unavailable- added by involution (Updated the item)
  • -unavailable- added by slowthinker (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 21 Apr 2015 04:51:33 PM UTCinvolutionAssigned toinvolution=>None
    Mon 28 Apr 2014 03:58:09 AM UTCinvolutionStatusIn Progress=>Postponed
    Wed 09 Apr 2014 05:09:14 PM UTCinvolutionSeverity3 - Normal=>4 - Important
      StatusNone=>In Progress
      Assigned toNone=>involution
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup