patchBattle for Wesnoth - Patches: patch #2625, Control panel window

 
 
Show feedback again

patch #2625: Control panel window

Submitted by:  Lukasz Dobrogowski <zaroth>
Submitted on:  Wed 06 Apr 2011 08:08:56 PM UTC  
 
Priority: 5 - NormalStatus: Done
Privacy: PublicAssigned to: Mark de Wever <mordante>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 10 Apr 2011 04:40:40 PM UTC, SVN revision 49172:

Add a new give_control command.

Applies patch #2625 with some minor modifications.

(Browse SVN revision 49172)

Mark de Wever <mordante>
Project MemberIn charge of this item.
Sun 10 Apr 2011 09:12:47 AM UTC, comment #8:

added hiding of "[side] hidden=yes" sides and fixed a bug with empty player names.

(file #12829)

Lukasz Dobrogowski <zaroth>
Project Member
Sat 09 Apr 2011 09:07:48 PM UTC, comment #7:

made it apply cleanly to the recent trunk.

(file #12828)

Lukasz Dobrogowski <zaroth>
Project Member
Sat 09 Apr 2011 08:26:08 PM UTC, comment #6:

included suggestions from IRC.

(file #12827)

Lukasz Dobrogowski <zaroth>
Project Member
Sat 09 Apr 2011 07:56:27 AM UTC, comment #5:

Wrong file added previous time.

(file #12824)

Lukasz Dobrogowski <zaroth>
Project Member
Sat 09 Apr 2011 07:53:58 AM UTC, comment #4:

Just fixed my damn unit tests, adding a few checks for the never-happening case that no sides or no nicks were added wasn't that painful.

For your convenience, I wrapped up the unit tests fix, team color convenience function ( https://gna.org/patch/?2628 ) and the initial mp_change_control dialog patch into one big patch. It should apply cleanly to the current trunk.

(file #12823)

Lukasz Dobrogowski <zaroth>
Project Member
Fri 08 Apr 2011 10:02:04 PM UTC, comment #3:

Just noticed that my class doesn't pass unit tests. Oh well.
(It's due to not checking if the listbox index of currently selected row isn't out of bounds, i.e. -1).

If it happened due to a feature that I plan holding onto, I'd happily take care of it, but since ultimately ( http://i.imgur.com/8jxHT.png ) I plan on not using selectable listboxes altogether, so... could we save me some work and ignore the unit tests for now, please ? ;-)

Lukasz Dobrogowski <zaroth>
Project Member
Fri 08 Apr 2011 09:44:47 PM UTC, comment #2:

Uploaded even more final version ;-)

I took into account all your remarks, mordante, except the one concerning moving get_view() and all the declarations to the private: section. But I guess it's not a big blocker (nobody's gonna try to access it from outside anyway) and if you don't have any further remarks, I'd like to have it committed in its current form.

(file #12819)

Lukasz Dobrogowski <zaroth>
Project Member
Fri 08 Apr 2011 06:35:20 PM UTC, comment #1:

hopefully final version of the patch is ready!

(file #12817)

Lukasz Dobrogowski <zaroth>
Project Member
Wed 06 Apr 2011 08:08:56 PM UTC, original submission:

Following fendrin's advice, I submit my (unfinished) state of the control panel dialog. It displays just dummy strings inside right now, but is developed enough to trigger an assertion fail in grid.cpp:541 which was labeled "this shouldn't happen".

In the patch I also moved the helper dialog_view_callback template function from gamestate_inspector.cpp to helper.hpp, since it's now used by two .cpp files and therefore worth putting outside.

Lukasz Dobrogowski <zaroth>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #12829:  change_control_iteration_n_2.patch added by zaroth (25kB - application/octet-stream)
file #12828:  change_control_iteration_n_1.patch added by zaroth (25kB - application/octet-stream)
file #12827:  change_control_iteration_n.patch added by zaroth (28kB - application/octet-stream)
file #12823:  team_color_convenience_function.patch added by zaroth (3kB - application/octet-stream)
file #12819:  change_control_dialog2.patch added by zaroth (25kB - application/octet-stream)
file #12817:  change_control_dialog.patch added by zaroth (23kB - application/octet-stream)
file #12807:  control_panel_beta.patch added by zaroth (20kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mordante (Updated the item)
  • -unavailable- added by fendrin (Updated the item)
  • -unavailable- added by zaroth (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 08 May 2011 04:46:02 PM UTCivanovicOpen/ClosedOpen=>Closed
    Sun 10 Apr 2011 04:22:40 PM UTCmordanteStatusNone=>Done
    Sun 10 Apr 2011 09:12:47 AM UTCzarothAttached File-=>Added change_control_iteration_n_2.patch, #12829
    Sat 09 Apr 2011 09:07:48 PM UTCzarothAttached File-=>Added change_control_iteration_n_1.patch, #12828
    Sat 09 Apr 2011 08:26:08 PM UTCzarothAttached File-=>Added change_control_iteration_n.patch, #12827
    Sat 09 Apr 2011 07:56:27 AM UTCzarothAttached File-=>Added change_control_dialog_unit_tests_team_color_function.patch, #12824
    Sat 09 Apr 2011 07:53:57 AM UTCzarothAttached File-=>Added team_color_convenience_function.patch, #12823
    Fri 08 Apr 2011 09:44:47 PM UTCzarothAttached File-=>Added change_control_dialog2.patch, #12819
    Fri 08 Apr 2011 06:35:20 PM UTCzarothAttached File-=>Added change_control_dialog.patch, #12817
    Wed 06 Apr 2011 08:18:37 PM UTCfendrinAssigned toNone=>mordante
    Wed 06 Apr 2011 08:08:56 PM UTCzarothAttached File-=>Added control_panel_beta.patch, #12807
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup